Conversation
OEvgeny
reviewed
Sep 8, 2025
compulim
commented
Sep 8, 2025
compulim
commented
Sep 8, 2025
OEvgeny
reviewed
Sep 8, 2025
OEvgeny
reviewed
Sep 8, 2025
OEvgeny
reviewed
Sep 9, 2025
OEvgeny
previously approved these changes
Sep 9, 2025
Co-authored-by: Eugene <EOlonov@gmail.com>
OEvgeny
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
<meta>tag, in PR #5571, by @compulimDescription
Today, build info is aggregated and injected by the bundle package at once.
Tomorrow, build info will be exported by individual package on import:
api,bundle,core,component,debug-theme,fluent-theme.This pull request is part of the clean up of bundle package, which is part of the C2 modernization workstream.
Foundation change for C2 modernization
Today, the bundle package includes entry points and code (e.g. Adaptive Cards.)
Tomorrow, the bundle package will only includes entry point. The code will be split into another package. This enables multiple entry points:
<script>)globalThis.Reactand fallback to bundled React<script type="module">)<script>globalThis.Reactfallback to bundled<script type="module">globalThis.Reactfallback to bundledDesign
Every package will have their own build info.
Specific Changes
tsupoutput atomicallydist.tmpand copy todiston success--onSuccessintotsup.config.ts<meta>tag into@msinternal/botframework-webchat-basepackagedefineinstead ofenvfor build infoglobalThis.WEB_CHAT_BUILD_INFO_BUILD_TOOListsupglobalThis.WEB_CHAT_BUILD_INFO_MODULE_FORMATiscommonjs,esmodulesorglobalglobalThis.WEB_CHAT_BUILD_INFO_VERSIONchange-case/kebab-casefor injecting into<meta>change-caseneeds to bedevDependenciesas it is ESM onlytsupconfig (tsup.config.bundled_*.mjs) to.gitignore.gitignorelint-stagedconfigprecommit:eslint:*andprecommit:typecheck:*<meta>and boot<meta name="botframework-webchat:ui:version"><meta name="botframework-webchat:bundle:variant"><meta name="botframework-webchat">from<meta name="botframework-webchat:bundle">CHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)